1. Syntax error on the consular_protection.css:501 Please fix it!
You should use an empty line under the last break statement inside the switch of consular_protection_preprocess_search_results and consular_protection_preprocess_block function.
drush dcs sites/all/themes/consular_protection/
FILE: ...multisite_drupal_jku1/sites/all/themes/consular_protection/template.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
341 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------
FILE: ...all/themes/consular_protection/templates/blocks/block--block--2.tpl.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | End of line character is invalid; expected "\n" but found "\r\n"
114 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...all/themes/consular_protection/templates/blocks/block--block--4.tpl.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | End of line character is invalid; expected "\n" but found "\r\n"
115 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...ection/templates/blocks/block--easy-breadcrumb--easy-breadcrumb.tpl.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | End of line character is invalid; expected "\n" but found "\r\n"
62 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...s/consular_protection/templates/blocks/block--system--main-menu.tpl.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | End of line character is invalid; expected "\n" but found "\r\n"
52 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...jku1/sites/all/themes/consular_protection/templates/global/html.tpl.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | End of line character is invalid; expected "\n" but found "\r\n"
24 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...jku1/sites/all/themes/consular_protection/templates/global/page.tpl.php
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | End of line character is invalid; expected "\n" but found "\r\n"
2 | ERROR | You must use "/**" style comments for a file comment
2 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
237 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...s/search/search-result--apachesolr-search--node--representation.tpl.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | End of line character is invalid; expected "\n" but found "\r\n"
103 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...es/search/search-result--apachesolr-search--node--travel_advice.tpl.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | End of line character is invalid; expected "\n" but found "\r\n"
92 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: .../all/themes/consular_protection/templates/search/search-results.tpl.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
74 | ERROR | Language constructs must be followed by a single space; expected
| | "print (" but found "print("
--------------------------------------------------------------------------------
PHP_CodeSniffer found at least one issue. [error]
2.
You should rename the consular_proctection_add_bt_class function, there is just a typo bug, but it needs a fix based on our rules!
3.
Result of the deep code review:
- You should rewrite the phpdoc above consular_protection_preprocess_page function, the origin hook isn't a theme_ function, there is a template_ one.
- Please add more phpdoc to your custom functions (not the implementations of hooks) - params, returns are missing.
- If you want to use a helper function, please add a _ character at the beginning of the name of function.
- Where do you use consular_protection_sort_by_country function in your theme, because we didn't find any call of it! Maybe that is a legacy code? If it is please remove from the delivery.
- You should the l() built-in drupal function instead of directly using an <a> html tag in your consular_protection_preprocess_search_results implementation regarding the travel_advice_url variable.
- You should use the t() function for result_type variables (twice!) inside consular_protection_preprocess_search_results function.
- Please use the str_replace with arrays instead of the present version with 5 calls of this php built-in function.
- Please remove the unused $out variable from consular_protection_get_node_info function.
- Please use the theme_image() function instead of directly using of <img> html tag in line 508.
- Please refactor your usage of field_body inside the consular_protection_get_node_info function, because this is quite misunderstanding. Our problem is why do you want to use the body field as an integer? Maybe you should define a custom field and use this functionality with that. If you want you can skip this recommendation, because it is bigger than the theme part.
- Please use the "implements" format above the consular_protection_apachesolr_search_noresults function, because this is an implementation of theme_apachesolr_search_noresults function.